You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Block Creation of Transaction-Based Alerts via API When Flag is Enabled
This PR prevents users from creating transaction alerts via the API by raising a validation error when the organizations:discover-saved-queries-deprecation feature flag is enabled. The enforcement, previously implemented in the UI, is now mirrored in backend validation to ensure users cannot circumvent the restriction through API usage. Additional backend and serializer tests ensure correct error messaging and validation for deprecated datasets.
Key Changes
• Added validation in SnubaQueryValidator._validate_performance_dataset to reject transactions and generic_metrics datasets if the organizations:discover-saved-queries-deprecation flag is active
• Updated tests in tests/sentry/incidents/endpoints/test_organization_alert_rule_index.py to assert correct error handling for deprecated datasets via the API
• Added new tests in tests/sentry/incidents/endpoints/test_serializers.py to confirm serializer-level rejections with feature flag enabled
Affected Areas
• src/sentry/snuba/snuba_query_validator.py (dataset validation logic)
• tests/sentry/incidents/endpoints/test_organization_alert_rule_index.py (API endpoint test coverage)
• tests/sentry/incidents/endpoints/test_serializers.py (serializer behavior test coverage)
This summary was automatically generated by @propel-code-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's already prevented in the UI when the flag is enabled
Copied from getsentry#101177
Original PR: getsentry#101177